Skip to content

HBASE-23259: Populate master address end points in cluster/rs configs #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndimiduk merged 1 commit into from
Nov 21, 2019
Merged

HBASE-23259: Populate master address end points in cluster/rs configs #857

ndimiduk merged 1 commit into from
Nov 21, 2019

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Nov 20, 2019

All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk [email protected]

@bharathv @ndimiduk
HBASE-23259: Populate master address end points in cluster/rs configs (…
1907b9b 
…apache#807)

All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk <[email protected]>
@ndimiduk ndimiduk mentioned this pull request Nov 20, 2019
Merged
@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 5m 18s branch-2 passed
+1 💚 compile 1m 22s branch-2 passed
+1 💚 checkstyle 1m 57s branch-2 passed
+1 💚 shadedjars 4m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 3s branch-2 passed
+0 🆗 spotbugs 4m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 56s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 5m 19s the patch passed
+1 💚 compile 1m 17s the patch passed
+1 💚 javac 1m 17s the patch passed
+1 💚 checkstyle 0m 28s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 1m 21s hbase-server: The patch generated 0 new + 35 unchanged - 1 fixed = 35 total (was 36)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 15m 28s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 56s the patch passed
+1 💚 findbugs 4m 20s the patch passed
_ Other Tests _
+1 💚 unit 3m 0s hbase-common in the patch passed.
-1 ❌ unit 167m 35s hbase-server in the patch failed.
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
232m 11s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/Dockerfile
GITHUB PR #857
JIRA Issue HBASE-23259
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 26b99378b9ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-857/out/precommit/personality/provided.sh
git revision branch-2 / 7e088da
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/testReport/
Max. process+thread count 4696 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-857/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Nov 21, 2019

The only failure here is an instance of HBASE-22470.

@ndimiduk ndimiduk merged commit d742112 into apache:branch-2 Nov 21, 2019
@ndimiduk ndimiduk deleted the 23259-backport-branch-2 branch November 21, 2019 17:44
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@ndimiduk @Apache9
HBASE-23259: Populate master address end points in cluster/rs configs (…
a1f5a5f 
…apache#807) (apache#857)

All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk @Apache-HBase @bharathv